Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix panic when accessing unexported struct field #99

Merged
merged 2 commits into from
Oct 22, 2021
Merged

Fix panic when accessing unexported struct field #99

merged 2 commits into from
Oct 22, 2021

Conversation

dearoneesama
Copy link
Contributor

fixes the panicking caused by below code:

structData := struct {
	Name string `msg:"name"`
	private string
 } {
	"john smith",
	"",
}
f.Post("tag_name", structData)

@dearoneesama
Fix panic on accessing unexported struct field
31d91bf 
They cannot be retrieved for values so one needs to skip them. This aligns with the json.marshal behavior

Signed-off-by: dearoneesama <57923352+dearoneesama@users.noreply.github.com>
@batara666
Copy link

LGTM!

@tagomoris
Copy link
Member

I've updated the CI configuration to use GitHub Actions on #101
@dearoneesama Could you rebase this branch on the current master?

@tagomoris tagomoris merged commit 68780af into fluent:master Oct 22, 2021
@tagomoris
Copy link
Member

Tagged as v1.6.3

akerouanton added a commit to akerouanton/docker that referenced this pull request Nov 1, 2021
@akerouanton
vendor: github.com/fluent/fluent-logger-golang v1.7.0
b9e18d2 
Updates the fluent logger library to v1.7.0. Following PRs were merged
since last bump:

* [Add callback for error handling when using
  async](fluent/fluent-logger-golang#97)
* [Fix panic when accessing unexported struct
  field](fluent/fluent-logger-golang#99)
* [Properly stop logger during (re)connect
  failure](fluent/fluent-logger-golang#82)

Signed-off-by: Albin Kerouanton <albinker@gmail.com>
akerouanton added a commit to akerouanton/docker that referenced this pull request Nov 1, 2021
@akerouanton
vendor: github.com/fluent/fluent-logger-golang v1.7.0
58ada36 
Updates the fluent logger library to v1.7.0. Following PRs were merged
since last bump:

* [Add callback for error handling when using
  async](fluent/fluent-logger-golang#97)
* [Fix panic when accessing unexported struct
  field](fluent/fluent-logger-golang#99)
* [Properly stop logger during (re)connect
  failure](fluent/fluent-logger-golang#82)

See https://github.com/fluent/fluent-logger-golang/compare/v1.6.1..v1.7.0

Signed-off-by: Albin Kerouanton <albinker@gmail.com>
akerouanton added a commit to akerouanton/docker that referenced this pull request Dec 2, 2021
@akerouanton
vendor: github.com/fluent/fluent-logger-golang v1.8.0
e24d61b 
Updates the fluent logger library to v1.8.0. Following PRs/commits were
merged since last bump:

* [Add callback for error handling when using
  async](fluent/fluent-logger-golang#97)
* [Fix panic when accessing unexported struct
  field](fluent/fluent-logger-golang#99)
* [Properly stop logger during (re)connect
  failure](fluent/fluent-logger-golang#82)
* [Support a TLS-enabled connection](fluent/fluent-logger-golang@e5d6aa1)

See https://github.com/fluent/fluent-logger-golang/compare/v1.6.1..v1.8.0

Signed-off-by: Albin Kerouanton <albinker@gmail.com>
docker-jenkins pushed a commit to docker-archive/docker-ce that referenced this pull request Dec 2, 2021
@akerouanton
vendor: github.com/fluent/fluent-logger-golang v1.8.0
78d8de7 
Updates the fluent logger library to v1.8.0. Following PRs/commits were
merged since last bump:

* [Add callback for error handling when using
  async](fluent/fluent-logger-golang#97)
* [Fix panic when accessing unexported struct
  field](fluent/fluent-logger-golang#99)
* [Properly stop logger during (re)connect
  failure](fluent/fluent-logger-golang#82)
* [Support a TLS-enabled connection](fluent/fluent-logger-golang@e5d6aa1)

See https://github.com/fluent/fluent-logger-golang/compare/v1.6.1..v1.8.0

Signed-off-by: Albin Kerouanton <albinker@gmail.com>
Upstream-commit: e24d61b7efac787ff3d5176d994608937a057522
Component: engine
@akerouanton akerouanton mentioned this pull request Dec 26, 2021
Merged
evol262 pushed a commit to evol262/moby that referenced this pull request Jan 12, 2022
@akerouanton
vendor: github.com/fluent/fluent-logger-golang v1.8.0
4f3641e 
Updates the fluent logger library to v1.8.0. Following PRs/commits were
merged since last bump:

* [Add callback for error handling when using
  async](fluent/fluent-logger-golang#97)
* [Fix panic when accessing unexported struct
  field](fluent/fluent-logger-golang#99)
* [Properly stop logger during (re)connect
  failure](fluent/fluent-logger-golang#82)
* [Support a TLS-enabled connection](fluent/fluent-logger-golang@e5d6aa1)

See https://github.com/fluent/fluent-logger-golang/compare/v1.6.1..v1.8.0

Signed-off-by: Albin Kerouanton <albinker@gmail.com>
PettitWesley added a commit to PettitWesley/moby that referenced this pull request Jan 12, 2022
@PettitWesley
vendor: github.com/fluent/fluent-logger-golang v1.8.0
e05273c 
Updates the fluent logger library to v1.8.0. Following PRs/commits were
merged since last bump:

* [Add callback for error handling when using
  async](fluent/fluent-logger-golang#97)
* [Fix panic when accessing unexported struct
  field](fluent/fluent-logger-golang#99)
* [Properly stop logger during (re)connect
  failure](fluent/fluent-logger-golang#82)
* [Support a TLS-enabled connection](fluent/fluent-logger-golang@e5d6aa1)

See https://github.com/fluent/fluent-logger-golang/compare/v1.6.1..v1.8.0

Signed-off-by: Wesley <wppttt@amazon.com>
PettitWesley pushed a commit to PettitWesley/moby that referenced this pull request Jan 13, 2022
@akerouanton @PettitWesley
vendor: github.com/fluent/fluent-logger-golang v1.8.0
81fc02b 
Updates the fluent logger library to v1.8.0. Following PRs/commits were
merged since last bump:

* [Add callback for error handling when using
  async](fluent/fluent-logger-golang#97)
* [Fix panic when accessing unexported struct
  field](fluent/fluent-logger-golang#99)
* [Properly stop logger during (re)connect
  failure](fluent/fluent-logger-golang#82)
* [Support a TLS-enabled connection](fluent/fluent-logger-golang@e5d6aa1)

See https://github.com/fluent/fluent-logger-golang/compare/v1.6.1..v1.8.0

Signed-off-by: Albin Kerouanton <albinker@gmail.com>
(cherry picked from commit e24d61b)
Signed-off-by: Wesley <wppttt@amazon.com>
lmbarros pushed a commit to balena-os/balena-engine that referenced this pull request Nov 22, 2022
@akerouanton @lmbarros
vendor: github.com/fluent/fluent-logger-golang v1.8.0
88a0241 
Updates the fluent logger library to v1.8.0. Following PRs/commits were
merged since last bump:

* [Add callback for error handling when using
  async](fluent/fluent-logger-golang#97)
* [Fix panic when accessing unexported struct
  field](fluent/fluent-logger-golang#99)
* [Properly stop logger during (re)connect
  failure](fluent/fluent-logger-golang#82)
* [Support a TLS-enabled connection](fluent/fluent-logger-golang@e5d6aa1)

See https://github.com/fluent/fluent-logger-golang/compare/v1.6.1..v1.8.0

Signed-off-by: Albin Kerouanton <albinker@gmail.com>
(cherry picked from commit e24d61b)
Signed-off-by: Wesley <wppttt@amazon.com>
lmbarros pushed a commit to balena-os/balena-engine that referenced this pull request Nov 22, 2022
@akerouanton @lmbarros
vendor: github.com/fluent/fluent-logger-golang v1.8.0
feb7df8 
Updates the fluent logger library to v1.8.0. Following PRs/commits were
merged since last bump:

* [Add callback for error handling when using
  async](fluent/fluent-logger-golang#97)
* [Fix panic when accessing unexported struct
  field](fluent/fluent-logger-golang#99)
* [Properly stop logger during (re)connect
  failure](fluent/fluent-logger-golang#82)
* [Support a TLS-enabled connection](fluent/fluent-logger-golang@e5d6aa1)

See https://github.com/fluent/fluent-logger-golang/compare/v1.6.1..v1.8.0

Signed-off-by: Albin Kerouanton <albinker@gmail.com>
(cherry picked from commit e24d61b)
Signed-off-by: Wesley <wppttt@amazon.com>
lmbarros pushed a commit to balena-os/balena-engine that referenced this pull request Dec 8, 2022
@akerouanton @lmbarros
vendor: github.com/fluent/fluent-logger-golang v1.8.0
5835ab0 
Updates the fluent logger library to v1.8.0. Following PRs/commits were
merged since last bump:

* [Add callback for error handling when using
  async](fluent/fluent-logger-golang#97)
* [Fix panic when accessing unexported struct
  field](fluent/fluent-logger-golang#99)
* [Properly stop logger during (re)connect
  failure](fluent/fluent-logger-golang#82)
* [Support a TLS-enabled connection](fluent/fluent-logger-golang@e5d6aa1)

See https://github.com/fluent/fluent-logger-golang/compare/v1.6.1..v1.8.0

Signed-off-by: Albin Kerouanton <albinker@gmail.com>
(cherry picked from commit e24d61b)
Signed-off-by: Wesley <wppttt@amazon.com>
lmbarros pushed a commit to balena-os/balena-engine that referenced this pull request Dec 21, 2022
@akerouanton @lmbarros
vendor: github.com/fluent/fluent-logger-golang v1.8.0
6aa1df6 
Updates the fluent logger library to v1.8.0. Following PRs/commits were
merged since last bump:

* [Add callback for error handling when using
  async](fluent/fluent-logger-golang#97)
* [Fix panic when accessing unexported struct
  field](fluent/fluent-logger-golang#99)
* [Properly stop logger during (re)connect
  failure](fluent/fluent-logger-golang#82)
* [Support a TLS-enabled connection](fluent/fluent-logger-golang@e5d6aa1)

See https://github.com/fluent/fluent-logger-golang/compare/v1.6.1..v1.8.0

Signed-off-by: Albin Kerouanton <albinker@gmail.com>
(cherry picked from commit e24d61b)
Signed-off-by: Wesley <wppttt@amazon.com>
lmbarros pushed a commit to balena-os/balena-engine that referenced this pull request Feb 7, 2023
@akerouanton @lmbarros
vendor: github.com/fluent/fluent-logger-golang v1.8.0
6ae9105 
Updates the fluent logger library to v1.8.0. Following PRs/commits were
merged since last bump:

* [Add callback for error handling when using
  async](fluent/fluent-logger-golang#97)
* [Fix panic when accessing unexported struct
  field](fluent/fluent-logger-golang#99)
* [Properly stop logger during (re)connect
  failure](fluent/fluent-logger-golang#82)
* [Support a TLS-enabled connection](fluent/fluent-logger-golang@e5d6aa1)

See https://github.com/fluent/fluent-logger-golang/compare/v1.6.1..v1.8.0

Signed-off-by: Albin Kerouanton <albinker@gmail.com>
(cherry picked from commit e24d61b)
Signed-off-by: Wesley <wppttt@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dearoneesama @batara666 @tagomoris