Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FluentLoggerFactory fails to hold FluentLogger(s) over GC #38

Merged
merged 1 commit into from
Dec 7, 2014
Merged

Fix FluentLoggerFactory fails to hold FluentLogger(s) over GC #38

merged 1 commit into from
Dec 7, 2014

Conversation

komamitsu
Copy link
Member

For #37

@oza
Copy link
Member

oza commented Dec 6, 2014

@komamitsu Look good to me overall.

@komamitsu komamitsu mentioned this pull request Dec 7, 2014
Closed
oza added a commit that referenced this pull request Dec 7, 2014
@oza
Merge pull request #38 from fluent/issue37
857778c 
Fix FluentLoggerFactory to hold FluentLogger(s) over GC.
@oza oza merged commit 857778c into master Dec 7, 2014
@oza
Copy link
Member

oza commented Dec 7, 2014

Merged. Thanks for your PR, @komamitsu!

@oza oza deleted the issue37 branch December 7, 2014 10:45
@komamitsu
Copy link
Member Author

@oza :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@komamitsu @oza