Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compat 52 #17

Closed
wants to merge 5 commits into from
Closed

Compat 52 #17

wants to merge 5 commits into from

Conversation

kzk
Copy link
Member

@kzk kzk commented Mar 28, 2013

hi, seems like majority of Fluentd+PHP users are suffered from using PHP 5.2 or older. Could you apply this branch to master?

@chobie
Copy link
Member

chobie commented Apr 1, 2013

You know PHP 5.2 series is not supported anymore. So merging compat-52 branch to master is tough issue.

for 5.3 users:

pros: nothing
cons:

Specifically,

5.3 users could omit prefixes when useing use statement.

<?php
use Fluent\Logger;

$logger = FluentLogger::open()

compat-52 style can not omit class name. some people doesn't like this.

<?php

$logger = Fluent_Logger_FluentLogger::open()

for 5.2 users:

pros:

  • easy to use. just git clone.

but this also could 'git clone --branch=compat-52 https://github.com/fluent/fluent-logger-php.git'

cons: nothing

but I know many PHP5.2 application still provides good services. so we can choose these choices.

most 5.3 users use composer to manage dependencies. I guess this solution is less impact to current user.

  • C: Change major version and merge this.

@sotarok what do you think about this issue?

@DQNEO
Copy link
Member

DQNEO commented May 2, 2015

@kzk Hello I become a new maintainer of this project.

Now in 2015, PHP 5.2 and 5.3 are already EOL
http://php.net/eol.php

So I suppose there is no need to maintain this branch.
I made a tag to save this tree for someone who wants to get this.
https://github.com/fluent/fluent-logger-php/releases/tag/php52

Thank you for your contributions.

@DQNEO DQNEO closed this May 2, 2015
@DQNEO DQNEO deleted the compat-52 branch May 2, 2015 08:43
@DQNEO DQNEO restored the compat-52 branch May 2, 2015 08:44
@DQNEO DQNEO deleted the compat-52 branch May 2, 2015 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants