Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for extra env vars in fluentd helm chart. #942

Closed
andcri opened this issue Oct 2, 2023 · 1 comment · Fixed by #977
Closed

Allow for extra env vars in fluentd helm chart. #942

andcri opened this issue Oct 2, 2023 · 1 comment · Fixed by #977
Labels
good first issue Good for newcomers

Comments

@andcri
Copy link

andcri commented Oct 2, 2023

Is your feature request related to a problem? Please describe.

Hello, I m trying to add some env vars to the fluentd pod trough the helm chart of the fluent-operator.
I see that that feature exists in the fluentbit template but not in the fluentd one.

Describe the solution you'd like

I see here https://github.com/fluent/fluent-operator/blob/master/pkg/operator/sts.go#L144-L146 that fluentd supports the addition of extra environment variables by adding the EnvVars is it possible to have that added in the template here https://github.com/fluent/fluent-operator/blob/master/charts/fluent-operator/templates/fluentd-fluentd.yaml in the same way that is added in the fluentbit template?

Thanks :)

Additional context

No response

@andcri andcri changed the title envVars implementation exists for fluentd but it is not reflected on the Helm Chart Allow for extra env vars in fluentd helm chart. Oct 2, 2023
@wenchajun wenchajun added the good first issue Good for newcomers label Oct 2, 2023
@wenchajun
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants