fix(fluentd): Use custom plugin content for hash generation #1059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maximilian Blatt <maximilian.blatt-extern@deutschebahn.com>
benjaminhuo
approved these changes
Feb 7, 2024
|
Thank you @MisterMX |
|
Thank! I can confirm it works now. Previously only a single ClusterInput was included in the fluentd config, now all selected ClusterInput definitions appear in the config secret. |
|
@benjaminhuo we would also really appreciate it if this could make it into a backport or fix release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
This fixes a small issue regarding custom plugins by adding
PluginStore.Contentto the hash generation. Otherwise every custom plugin would have the same hash and only one would be added to the final config.Since
PluginStore.Contentis empty for all plugins except custom ones it is safe to just set it when calculating the hash.Does this PR introduced a user-facing change?
No.
Additional documentation, usage docs, etc.:
n.a.