Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: attach latest tag to images - DockerHub synchronize with GHCR #1086

Merged
merged 7 commits into from Mar 10, 2024

Conversation

sarathchandra24
Copy link
Collaborator

What this PR does / why we need it:

This PR solves the problem of not pushing the latest tag to docker hub. Pushing this tag is mandatory as discussed in the PR #1079

Which issue(s) this PR fixes:

Fixes #1068

GitHub action jobs - than ran on my personal credentials with tag v23.1.1 - this is just a temporary tag to check the creation of images.

Fluentd Job
Fluent-Bit Job - In Progress
Fluent Operator Job

Verification of images pushed to docker hub:
fluent-operator
fluentbit
fluentd

Does this PR introduced a user-facing change?


Additional documentation, usage docs, etc.:

As per this containers/image#447 discussion --additional-tags is only copying to docker-archive.

Also copying manifests is also not helping

sarathchandra24 and others added 7 commits March 6, 2024 15:36
Signed-off-by: Sarath Chandra Oruganti <39090092+SarathChandra24@users.noreply.github.com>
Signed-off-by: Sarath Chandra Oruganti <sarathchandraoruganti@gmail.com>
Signed-off-by: Sarath Chandra Oruganti <39090092+SarathChandra24@users.noreply.github.com>
Signed-off-by: Sarath Chandra Oruganti <sarathchandraoruganti@gmail.com>
Signed-off-by: Sarath Chandra Oruganti <sarathchandraoruganti@gmail.com>
Signed-off-by: Sarath Chandra Oruganti <sarathchandraoruganti@gmail.com>
Signed-off-by: Sarath Chandra Oruganti <sarathchandraoruganti@gmail.com>
@benjaminhuo benjaminhuo merged commit 2f49673 into fluent:master Mar 10, 2024
14 of 17 checks passed
@benjaminhuo
Copy link
Member

it works, thank you @sarathchandra24
image

chrono2002 pushed a commit to chrono2002/fluent-operator that referenced this pull request Mar 12, 2024
…luent#1086)

* push image to multiple registry

Signed-off-by: Sarath Chandra Oruganti <39090092+SarathChandra24@users.noreply.github.com>
Signed-off-by: Sarath Chandra Oruganti <sarathchandraoruganti@gmail.com>

* github actions permissions

Signed-off-by: Sarath Chandra Oruganti <39090092+SarathChandra24@users.noreply.github.com>
Signed-off-by: Sarath Chandra Oruganti <sarathchandraoruganti@gmail.com>

* fluentd multi registry image push

Signed-off-by: Sarath Chandra Oruganti <sarathchandraoruganti@gmail.com>

* Limit build to PR changes for certain files

Signed-off-by: Sarath Chandra Oruganti <sarathchandraoruganti@gmail.com>

* Fix: Latest tag while pushing to docker hub

Signed-off-by: Sarath Chandra Oruganti <sarathchandraoruganti@gmail.com>

---------

Signed-off-by: Sarath Chandra Oruganti <39090092+SarathChandra24@users.noreply.github.com>
Signed-off-by: Sarath Chandra Oruganti <sarathchandraoruganti@gmail.com>
Signed-off-by: Paul Smith <chrono2002@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kubesphere fluent* images should be published to multiple registries
2 participants