Fixes "build fluent operator" CI workflow #1263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@benjaminhuo It looks like this PR workflow has been failing with the same error for a while now (403 forbidden) so I think we may have something else going on here: But -- the error introduced by my changes has been fixed in this PR. |
joshuabaird
changed the title
Signed-off-by: Josh Baird <jbaird@galileo.io>
Signed-off-by: Josh Baird <jbaird@galileo.io>
joshuabaird
force-pushed
the
chore/fix-ci-op
branch
from
7a5ca19
to
2fe0d59
Compare
joshuabaird
commented
Jul 25, 2024
| @@ -384,7 +384,7 @@ jobs: | |||
| - build-arm64-base-image-metadata | |||
| - build-arm64-base | |||
| with: | |||
| source_image: "${{ needs.build-arm64-base-image-metadata.outputs.IMG_NAME }}" | |||
| source_image: "${{ needs.build-arm64-base-image-metadata.outputs.IMG_NAME }}:${{ needs.build-arm64-base-image-metadata.outputs.version }}" | |||
There was a problem hiding this comment.
This fixes a bug where we were previously promoting fluentd-latest on GHCR to "debug" tags on Dockerhub:
Promoting ghcr.io/fluent/fluent-operator/fluentd to docker.io/kubesphere/fluentd:latest-arm64-base
This fix promotes the proper images:
Promoting ghcr.io/***/fluent-operator/fluentd:9.9.9-10-arm64-base to docker.io/kubesphere/fluentd:v9.9.9-10-arm64-base
benjaminhuo
approved these changes
Jul 25, 2024
Yeah, this is a bug not introduce by your PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1259 removed the
platforminput from theclone-docker-image-actionCI workflow but failed to remove it from being passed in the "build fluent operator" workflow which resulted in this error:This PR also fixes a Dockerhub promotion issue for the fluentd-arm64-base images.