Add priority class to FluentBit type #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bojan <dbojan@gmail.com>
Signed-off-by: Bojan <dbojan@gmail.com>
Signed-off-by: Bojan <dbojan@gmail.com>
bojand
force-pushed
the
do/priority_class_crd
branch
from
ee4b425
to
90b3993
Compare
benjaminhuo
reviewed
Oct 7, 2021
docs/crd.md
Outdated
| @@ -159,6 +159,7 @@ FluentBitSpec defines the desired state of FluentBit | |||
| | fluentBitConfigName | Fluentbitconfig object associated with this Fluentbit | string | | |||
| | secrets | The Secrets are mounted into /fluent-bit/secrets/<secret-name>. | []string | | |||
| | runtimeClassName | The runtimeClassName represents the container runtime configuration. | string | | |||
| | runtimeClassName | The priorityClassName represents the pod's priority. | string | | |||
There was a problem hiding this comment.
runtimeClassName should be priorityClassName?
Signed-off-by: Bojan <dbojan@gmail.com>
bojand
force-pushed
the
do/priority_class_crd
branch
from
569f46f
to
df570b1
Compare
wanjunlei
approved these changes
Oct 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
PriorityClassNameproperty toFluentBittype which translates toPriorityClassNamewithin the fluent bit daemonset.