Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the incorrect keys of the es output plugin #160

Merged
merged 1 commit into from Oct 31, 2021

Conversation

dkeven
Copy link
Contributor

@dkeven dkeven commented Oct 31, 2021

Signed-off-by: dkeven keven@kubesphere.io

When generating params from the Elasticsearch type, in:

https://github.com/fluent/fluentbit-operator/blob/4b96fcc0a7e19a5bb89f7051982d7bcee538b2a2/api/fluentbitoperator/v1alpha2/plugins/output/elasticsearch_types.go#L155-L159

,the config keys of the Type and Index fields are incorrectly set to Host if they are not empty, resulting in an overwriting of the true Host config, like in this issue: kubesphere/kubesphere#4395

Signed-off-by: dkeven <keven@kubesphere.io>
@dkeven
Copy link
Contributor Author

dkeven commented Oct 31, 2021

/cc @wenchajun @benjaminhuo @wanjunlei

@wenchajun
Copy link
Member

/lgtm

@benjaminhuo
Copy link
Member

@dkeven Good catch, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants