Add support for aws filter plugin #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wanjunlei
requested changes
Nov 26, 2021
| // The availability zone; for example, "us-east-1a". Default is true. | ||
| Az *bool `json:"az,omitempty"` | ||
| //The EC2 instance ID.Default is true. | ||
| Ec2InstanceId *bool `json:"ec2InstanceId,omitempty"` |
There was a problem hiding this comment.
Ec2InstanceId => EC2InstanceID
Ec2InstanceType => EC2InstanceType
PrivateIp => PrivateIP
AmiId => AmiID
AccountId => AccountID
VpcId => VpcID
wanjunlei
requested changes
Nov 26, 2021
| // +kubebuilder:object:generate:=true | ||
|
|
||
| // The AWS Filter Enriches logs with AWS Metadata. Currently the plugin adds the EC2 instance ID and availability zone to log records. | ||
| type Aws struct { |
| @@ -61,6 +61,8 @@ type FilterItem struct { | |||
| Throttle *filter.Throttle `json:"throttle,omitempty"` | |||
| // RewriteTag defines a RewriteTag configuration. | |||
| RewriteTag *filter.RewriteTag `json:"rewriteTag,omitempty"` | |||
| //Aws defines a Aws configuration. | |||
| Aws *filter.Aws `json:"aws,omitempty"` | |||
wanjunlei
reviewed
Nov 26, 2021
| // The availability zone; for example, "us-east-1a". Default is true. | ||
| Az *bool `json:"az,omitempty"` | ||
| //The EC2 instance ID.Default is true. | ||
| EC2InstanceID *bool `json:"ec2InstanceId,omitempty"` |
There was a problem hiding this comment.
ec2InstanceId => ec2InstanceID
privateIp => privateIP
amiId => amiID
accountId => accountID
vpcId => vpcID
There was a problem hiding this comment.
Sorry, I overlooked that
benjaminhuo
reviewed
Nov 26, 2021
| // +kubebuilder:validation:Enum:=v1;v2 | ||
| ImdsVersion string `json:"imdsVersion,omitempty"` | ||
| // The availability zone; for example, "us-east-1a". Default is true. | ||
| Az *bool `json:"az,omitempty"` |
There was a problem hiding this comment.
Az could be changed to AZ too
Signed-off-by: chengdehao <dehaocheng@yunify.com>
benjaminhuo
approved these changes
Nov 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR dose?
Adds support for https://docs.fluentbit.io/manual/pipeline/filters/aws-metadata filter plugin
Why we need it?
Fluentbit supports a variety of plug-ins, but not all fluentbit-operator adaptations. More plug-ins will be supported in the future, see the fields supported by the Filter plug-in
The final results
The configuration is written to secret
Signed-off-by: chengdehao dehaocheng@yunify.com