Feature: firehose plugin support #178
Conversation
|
Thanks for your contribution, but I didn't find firehose output plug-in in the official document, could you please provide me with a document or link? |
Sure, it's part of the AWS for fluentbit, specifically kinesis-firehose. Found some docs here as well 😊 |
| @@ -6,7 +6,7 @@ metadata: | |||
| labels: | |||
| app.kubernetes.io/name: fluent-bit | |||
| spec: | |||
| image: kubesphere/fluent-bit:v1.8.3 | |||
| image: peter-fluentbit:v1.8.10 | |||
There was a problem hiding this comment.
V1.8.3 does not support this plugin, or there is a bug in v1.8.3? If true, we should build a fluent bit image of v1.8.10.
There was a problem hiding this comment.
Again, local testing.
|
|
||
| // The Firehose output plugin, allows to ingest your records into AWS Firehose. | ||
| // https://github.com/aws/amazon-kinesis-firehose-for-fluent-bit | ||
| type Firehose struct { |
There was a problem hiding this comment.
Variable naming needs to be adjusted. Firstly, it is not recommended to use _ in the definition of crd, for example, delivery_stream should be changed to deliveryStream. Secondly, for acronyms, use uppercase, such as Arn => ARN, Sts => STS.
There was a problem hiding this comment.
Great - I'll fix!
|
Updated a bit, seems like I confused the old and new version of the firehose plugin. |
api/fluentbitoperator/v1alpha2/plugins/output/firehose_types.go
Outdated
Show resolved
Hide resolved
|
By the way, please add the |
Download dependencies and binary in Makefile target Signed-off-by: Peter Svensson <peter@sparetimecoders.com>
This plugin add support for the new kinesis_firehose plugin https://docs.fluentbit.io/manual/pipeline/outputs/firehose not the old firehose plugin. Signed-off-by: Peter Svensson <peter@sparetimecoders.com>
No description provided.