Added secret option to fluentbit depployment in helm chart #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Devesh <vrshu112@gmail.com>
|
Thank you for your contribution. Because of a recent commit #189 , |
wenchajun
approved these changes
Feb 10, 2022
|
I guess my base has all the latest commit, should I rebase to fluentbit-operator ? |
|
Yes, thank you for your contribution. Maybe we can submit this contribution in both |
|
I will switch branches to |
|
I gues, I will open another PR for that branch |
benjaminhuo
approved these changes
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Add secrets option in helm chart, by which you can define custom secrets which should be mounted to your fluentbit deployment. This help in adding Client certs or CA cert to the fluentBit deployment.
Fixed some typo error