helm support #204
Merged
helm support #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminhuo
reviewed
Feb 17, 2022
benjaminhuo
reviewed
Feb 17, 2022
| initContainers: | ||
| - name: setenv | ||
| image: {{ .Values.operator.initcontainer.image }}:{{ .Values.operator.initcontainer.tag }} | ||
| command: | ||
| - /bin/sh | ||
| - '-c' | ||
| - set -ex; | ||
| echo CONTAINER_ROOT_DIR=$(crictl info --output go-template --template '{{`{{.config.containerdRootDir}}`}}') > /fluentbit-operator/fluent-bit.env | ||
| echo CONTAINER_ROOT_DIR={{ .Values.logPath.containerd }} > /fluent-operator/fluent-bit.env |
There was a problem hiding this comment.
Refer to the changes in latest PR ac62edc#diff-11a3a526accdc2c72ddd4b8cf745ad478e23fa61a1ad80dd62d532e47cae40a7R33
@zhu733756 please have a discussion with @wenchajun on how to change this part
There was a problem hiding this comment.
fixed. This is used because it is the field that is the containerd or crio field. For docker environments, this field has been modified.
wenchajun
force-pushed
the
helm
branch
2 times, most recently
from
22ab064
to
3f64144
Compare
zhu733756
requested changes
Feb 18, 2022
charts/fluent-operator/templates/fluentd-output-elasticsearch.yaml
Outdated
Show resolved
Hide resolved
| enable: false | ||
| brokers: "<kafka broker list like xxx.xxx.xxx.xxx:9092,yyy.yyy.yyy.yyy:9092>" | ||
| fluentbit: | ||
| forward: |
There was a problem hiding this comment.
fluentbit also acts as a output layer to send to kafka or es. Pls fill back them.
Signed-off-by: chengdehao <dehaocheng@kubesphere.io>
zhu733756
approved these changes
Feb 18, 2022
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: chengdehao dehaocheng@kubesphere.io