New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use buildx to build multi arches #214
Conversation
Signed-off-by: zhu733756 <zhu733756@kubesphere.io>
|
||
# build-arm64: | ||
# runs-on: ubuntu-latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part takes more than 20 mins, and I've commented it out.
RUN curl -sL -o qemu-6.0.0.balena1-aarch64.tar.gz https://github.com/balena-io/qemu/releases/download/v6.0.0%2Bbalena1/qemu-6.0.0.balena1-aarch64.tar.gz && echo "$QEMU_DOWNLOAD_SHA256 *qemu-6.0.0.balena1-aarch64.tar.gz" | sha256sum -c - | tar zxvf qemu-6.0.0.balena1-aarch64.tar.gz -C . && mv qemu-6.0.0+balena1-aarch64/qemu-aarch64-static . | ||
|
||
# Fluentd main image | ||
FROM arm64v8/ruby:2.7-slim-bullseye |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we just From fluent/fluentd:v1.14.5-debian-arm64-1.0
and then add fluent-watcher files and then use a new entrypoint instead of copying all the Dockerfile for arm64 fluentd?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested gem install
steps that take more than 10 mins. And we have extra pkgs to install. I think it would help, but it would not improve as expected.
Signed-off-by: zhu733756 <zhu733756@kubesphere.io>
|
||
# Fluentd main image | ||
FROM kubesphere/fluentd:v1.14.4-arm64-base | ||
LABEL Description="Fluentd docker image" Vendor="Fluent Organization" Version="1.14.4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suppose the above file cmd/fluent-watcher/fluentd/Dockerfile.arm64.base
pushed this image.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls push this image or sync the image zhu733756/fluentd-plugins:base
before merging this pr.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
zhu733756/fluentd-plugins:base => kubesphere/fluentd:v1.14.4-arm64-base ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. But I don't actually have an ARM machine to test. Someone helps testing it is great.
Signed-off-by: zhu733756 zhu733756@kubesphere.io
enhance #213