Encrypt sensitive information #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenchajun
force-pushed
the
secret
branch
2 times, most recently
from
2f8c698
to
2dfb82e
Compare
wanjunlei
approved these changes
Feb 25, 2022
benjaminhuo
reviewed
Feb 26, 2022
| @@ -24,4 +22,8 @@ type Elasticsearch struct { | |||
| LogstashFormat *bool `json:"logstashFormat,omitempty"` | |||
| // LogstashPrefix defines the logstash prefix index name to write events when logstash_format is true (default: logstash). | |||
| LogstashPrefix *string `json:"logstashPrefix,omitempty"` | |||
| // Optional, The login credentials to connect to the Elasticsearch node (default: nil) | |||
There was a problem hiding this comment.
to the Elasticsearch node
=>
to Elasticsearch
|
The change looks good to me. |
LGTM. We have discussed it. Can you also add helm e2e test in anthor pr @wenchajun |
wenchajun
force-pushed
the
secret
branch
2 times, most recently
from
6214972
to
9e1078a
Compare
OK，I will do it later |
benjaminhuo
reviewed
Feb 26, 2022
| @@ -24,4 +22,8 @@ type Elasticsearch struct { | |||
| LogstashFormat *bool `json:"logstashFormat,omitempty"` | |||
| // LogstashPrefix defines the logstash prefix index name to write events when logstash_format is true (default: logstash). | |||
| LogstashPrefix *string `json:"logstashPrefix,omitempty"` | |||
| // Optional, The login credentials to connect to Elasticsearch node (default: nil) | |||
There was a problem hiding this comment.
It's not Elasticsearch node (default: nil)
Should be Elasticsearch, node and (default: nil) are not necessary
Signed-off-by: chengdehao <wenchajun@gmail.com>
benjaminhuo
approved these changes
Feb 26, 2022
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: chengdehao wenchajun@gmail.com