Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crio init container mount path #260

Merged
merged 2 commits into from
May 11, 2022

Conversation

gmarkey
Copy link
Contributor

@gmarkey gmarkey commented Apr 1, 2022

What this PR does / why we need it:

Fixes init container crash when using crio container runtime.

Which issue(s) this PR fixes:

Fixes #259

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:


@wenchajun
Copy link
Member

Seems that DCO failed, please commit with a signature.

git config --global user.name <name>
git config --global user.email <email>
git commit -s -m "xxx"

@benjaminhuo
Copy link
Member

Seems that DCO failed, please commit with a signature.

git config --global user.name <name>
git config --global user.email <email>
git commit -s -m "xxx"

@gmarkey , would you please sign your commit as the method mentioned above?

dco
Signed-off-by: Greg Markey <greg.markey@auros.global>
@benjaminhuo
Copy link
Member

benjaminhuo commented Apr 7, 2022

@gmarkey I think you need to sign like this:

## revert the additional sign commit
git reset --hard head^
## sign the original commit
git commit -s --amend
## force push the modified commit
git push -f

@benjaminhuo
Copy link
Member

@gmarkey I think you need to sign like this:

## revert the additional sign commit
git reset --hard head^
## sign the original commit
git commit -s --amend
## force push the modified commit
git push -f

@gmarkey Would you re-sign your commit as above?

@benjaminhuo benjaminhuo merged commit eeb44cc into fluent:master May 11, 2022
wenchajun pushed a commit to wenchajun/fluentbit-operator that referenced this pull request May 12, 2022
* Fix crio init container mount path

* dco

Signed-off-by: Greg Markey <greg.markey@auros.global>

Co-authored-by: Greg Markey <greg.markey@auros.global>
(cherry picked from commit eeb44cc)
Signed-off-by: chengdehao <dehaocheng@kubesphere.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid mountPath for fluent init container when using crio
3 participants