-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for User Defined Annotations #313
Conversation
5115b39
to
c5f655c
Compare
@wenchajun could you give approval for workflow runs on this PR? |
Okay, but it looks like you submitted an extra commit, can you rebase it? |
964a95f
to
fae6598
Compare
Here's the local e2e tests I ran locally.
|
Do we add an annotation to codes like https://github.com/fluent/fluent-operator/blob/master/controllers/fluentbit_controller.go#L147? |
Signed-off-by: Frank Greco Jr <fbgrecojr@me.com>
fae6598
to
fe1b95c
Compare
/lgtm |
Thanks for the contribution @frankgreco |
What this PR does / why we need it:
There is no way to inject annotations into FluentBit DaemonSet pods. This is problematic as I cannot add the necessary annotations to my Prometheus scraper to scape the metrics that these pods expose.
Which issue(s) this PR fixes:
Fixes #311
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: