feat: adding annotations to Dameon Set of fluent-bit #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael J. Wieneke <m.wieneke@sap.com>
momoXD007
force-pushed
the
ds_annotations
branch
from
7789f70
to
991f080
Compare
wenchajun
approved these changes
Nov 25, 2022
benjaminhuo
approved these changes
Nov 29, 2022
|
Thanks for your active contribution @momoXD007! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR will add annotations not only to fluent-bit pods, but also to the Daemon Set itself.
This is a slight detail I overlooked in my latest PR ( #468 )
Which issue(s) this PR fixes:
partially adresses #456
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: