Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add dnsPolicy to fluentbit, more options to kubernetes filter #528

Merged
merged 2 commits into from Feb 1, 2023

Conversation

jjsiv
Copy link
Collaborator

@jjsiv jjsiv commented Jan 28, 2023

Signed-off-by: Jedrzej Kotkowski jedrzejk143@gmail.com

What this PR does / why we need it:

  • Adds dnsPolicy option to FluentBit CRD
  • Adds these options to FluentBit k8s filter plugin: dnsRetries, dnsWaitTime, useKubelet, kubeletPort, kubeletHost, kubeMetaCacheTTL, kubeTokenTTL

Which issue(s) this PR fixes:

Fixes #524, #514

Does this PR introduced a user-facing change?

Users can now specify dnsPolicy for FluentBit as well as more options for Kubernetes filter plugin

Additional documentation, usage docs, etc.:


Signed-off-by: Jedrzej Kotkowski <jedrzejk143@gmail.com>
@benjaminhuo
Copy link
Member

benjaminhuo commented Jan 31, 2023

@jjsiv Thanks for this PR, it's a big enhancement!
Would you please run make docs-update to update the API docs?
You'll need to rebase your branch before run this because there're some other new code checked in already

Signed-off-by: Jedrzej Kotkowski <jedrzejk143@gmail.com>
@jjsiv
Copy link
Collaborator Author

jjsiv commented Jan 31, 2023

@benjaminhuo for whatever reason running docs-update didn't actually update the docs for kubernetes filter, only a bunch of other stuff that I didn't include in the commit. I added it manually, maybe it would be worth having a look at later

@benjaminhuo
Copy link
Member

@benjaminhuo for whatever reason running docs-update didn't actually update the docs for kubernetes filter, only a bunch of other stuff that I didn't include in the commit. I added it manually, maybe it would be worth having a look at later

Great, thank you!

@benjaminhuo benjaminhuo merged commit a20728f into fluent:master Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add dnsPolicy support to the FluentBit custom resource
3 participants