New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ability to customize metrics port #587
Conversation
By default, fluent-bit will not start the metrics server, so does it need to change the HttpServer to true and set the HttpPort when the |
I think in this case if the user specifies
|
Agree, @dh185221 can we add this to the metricsPort comments? https://github.com/fluent/fluent-operator/pull/587/files#diff-5c477d8ee7708b4cadb8cc2e2435185df0d8a187b6dc26e351b75a3d0547c422R91 |
This change allows a user to specify a metrics port as part of their `FluentBit` custom resource. This is useful for those who need to use a port other than 2020. An example of a partial FluentBit resource with this new property might look like this: ``` apiVersion: fluentbit.fluent.io/v1alpha2 kind: FluentBit metadata: name: fluent-bit namespace: fluent labels: app.kubernetes.io/name: fluent-bit spec: image: kubesphere/fluent-bit:v2.0.9 metricsPort: 32020 . . . ``` Signed-off-by: Dale Hille <dh185221@ncr.com>
Signed-off-by: Dale Hille <dh185221@ncr.com>
cbaace2
to
cd14b4c
Compare
Update the manifests that should have been updated with fluent#587 for the `metricsPort` addition. Signed-off-by: Dale Hille <dh185221@ncr.com>
What this PR does / why we need it:
This change allows a user to specify a metrics port as part of their
FluentBit
custom resource. This is useful for those who need to use a port other than 2020.Which issue(s) this PR fixes:
Fixes #
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: