Adding GCP Stackdriver Fluentbit Output Plugin #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harley Bates <HarleyBatesOfficial@yahoo.co.uk>
wenchajun
reviewed
Mar 9, 2023
| @@ -74,6 +74,8 @@ type OutputSpec struct { | |||
| DataDog *output.DataDog `json:"datadog,omitempty"` | |||
| // Firehose defines Firehose Output configuration. | |||
| Fireose *output.Firehose `json:"firehose,omitempty"` | |||
| // Stackdriver defines Stackdriver Output Configuration | |||
| Stackdriver *output.Stackdriver `json:"stackdriver,omitempty"` | |||
There was a problem hiding this comment.
Wouldn't StackDriver be better?
There was a problem hiding this comment.
Wouldn't
StackDriverbe better?
No the origial word is Stackdriver
benjaminhuo
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Part of the fluent-operator goal of adding more output plugins. Needed to further support the goal of the project (managing fluentd/fluentbit configuration via YAML manifests)
Which issue(s) this PR fixes:
No active issue for this
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: