fix: Fix the permissions in the cluster roles and bindings in helm #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JorgeReus
force-pushed
the
fix/cluster_role_helm_permissions
branch
6 times, most recently
from
d3c7839
to
5344d56
Compare
- Added list, get, watch, patch to the clusterrole resource - Added list, get, watch, patch to the clusterrolebinding resource Signed-off-by: Jorge Reus <j-g1996@live.com>
JorgeReus
force-pushed
the
fix/cluster_role_helm_permissions
branch
from
5344d56
to
ddfa6a9
Compare
benjaminhuo
approved these changes
Apr 3, 2023
|
Thanks @JorgeReus for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fix the helm template permissions for clusterrole and clusterrole bindings
Which issue(s) this PR fixes:
Fixes #646
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: