Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the YAML file for edge nodes to the Helm file #668

Merged
merged 1 commit into from Apr 6, 2023

Conversation

wenchajun
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduced a user-facing change?


Additional documentation, usage docs, etc.:


@@ -180,6 +180,12 @@ fluentbit:
systemd:
enable: true

edge:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

edge can be changed directly to kubeedge to be more specific

@@ -0,0 +1,13 @@
{{- if .Values.fluentbit.edge.enable -}}
apiVersion: fluentbit.fluent.io/v1alpha2
kind: ClusterOutput
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stdout output for edge can be removed

@@ -0,0 +1,13 @@
{{- if .Values.fluentbit.edge.enable -}}
apiVersion: fluentbit.fluent.io/v1alpha2
kind: ClusterOutput
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stdout output for edge can be removed

edge:
enable: false
prometheusRemoteWrite:
host: "<cloud-prometheus-service-host>"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
host: "<cloud-prometheus-service-host>"
# change the host to the address of a cloud-side Prometheus-compatible server that can receive Prometheus remote write data
host: "<cloud-prometheus-service-host>"

enable: false
prometheusRemoteWrite:
host: "<cloud-prometheus-service-host>"
port: "<cloud-prometheus-service-port>"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
port: "<cloud-prometheus-service-port>"
```suggestion
# change the port to the port of a cloud-side Prometheus-compatible server that can receive Prometheus remote write data
port: "<cloud-prometheus-service-port>"

Signed-off-by: dehaocheng <dehaocheng@kubesphere.io>
@wenchajun
Copy link
Member Author

fixed

@benjaminhuo benjaminhuo merged commit 8c0cee2 into fluent:master Apr 6, 2023
2 checks passed
@wenchajun wenchajun deleted the edge branch April 6, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants