Add missing record modifier options #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jean-Yves NOLEN <jynolen+github@gmail.com>
…to missing-record-modifier-operations Signed-off-by: Jean-Yves NOLEN <jynolen+github@gmail.com>
wenchajun
approved these changes
Apr 5, 2023
benjaminhuo
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Make recordmodifier insync with upstream spec
Which issue(s) this PR fixes:
Fixes #597
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.:
Added tests for validated both the logic and the validity of generated filter
Doc Procedure
Remarks
In
RecordModifier,Recordproperty should be a map[string]string but introduced breaking changes for users