Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add uri field for each telemetry type in opentelemetry plugin, remove old uri field #708

Merged
merged 4 commits into from May 4, 2023
Merged

Add uri field for each telemetry type in opentelemetry plugin, remove old uri field #708

merged 4 commits into from May 4, 2023

Conversation

JensLoe
Copy link
Contributor

@JensLoe JensLoe commented Apr 28, 2023

What this PR does / why we need it:

Adds a field for each telemetry type in the opentelemetry clusteroutput-plugin so it matches the fluent bit opentelemetry output, as described in the docs

Which issue(s) this PR fixes:

Fixes #707

Does this PR introduced a user-facing change?

Additional documentation, usage docs, etc.:

wenchajun
wenchajun requested changes Apr 29, 2023
View reviewed changes
Copy link
Member

@wenchajun wenchajun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should generate the appropriate CRD etc. files.

@wenchajun
Copy link
Member

make manifests
make generate

@JensLoe
Add uri field for each telemetry type, remove old uri field
c30275f 
Signed-off-by: Jens Mjønes Loe <jens_loe@hotmail.com>
@JensLoe
generate manifests with command "make manifests"
57777b0 
Signed-off-by: Jens Mjønes Loe <jens_loe@hotmail.com>
@JensLoe
run "make generate"
2a0979c 
Signed-off-by: Jens Mjønes Loe <jens_loe@hotmail.com>
@JensLoe
generate API-doc
75ce9ab 
Signed-off-by: Jens Mjønes Loe <jens_loe@hotmail.com>
@JensLoe
Copy link
Contributor Author

JensLoe commented Apr 29, 2023

I have generated the files by running make manifests and make generate. Also generated the API-docs by running go run cmd/doc-gen/main.go. Let me know if there is anything else i should do (or undo).

@benjaminhuo benjaminhuo merged commit c3e1dcb into fluent:master May 4, 2023
6 checks passed
@benjaminhuo
Copy link
Member

@JensLoe Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminhuo benjaminhuo benjaminhuo approved these changes

@wenchajun wenchajun wenchajun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the fluentbit opentelemetry clusteroutput-plugin to accept logs, metrics, and traces uri
3 participants
@JensLoe @wenchajun @benjaminhuo