Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fluentd in_tail plugin #753

Merged
merged 1 commit into from May 24, 2023
Merged

Fluentd in_tail plugin #753

merged 1 commit into from May 24, 2023

Conversation

jjsiv
Copy link
Collaborator

@jjsiv jjsiv commented May 22, 2023

What this PR does / why we need it:

This PR adds tail plugin to Fluentd globalInputs. It also enables setting tags for all Fluentd plugin types though I believe this has more or less no effect at the moment.

Which issue(s) this PR fixes:

Fixes #632

Does this PR introduced a user-facing change?

Users can now utilize tail input for Fluentd

Additional documentation, usage docs, etc.:

https://docs.fluentd.org/input/tail

Signed-off-by: Jedrzej Kotkowski <jedrzejk143@gmail.com>
@wenchajun
Copy link
Member

This is actually slightly different from the first design. The question is whether to add the tail plugin to the statefulset form of fluentd, or to rewrite a controller so that fluentd is deployed as a daemonset and then configure the tail plugin for it.

@jjsiv
Copy link
Collaborator Author

jjsiv commented May 23, 2023

I think it wouldn't be bad to have it on the statefulset as it can still be used there (although in a limited way). Obviously it would be best used on a daemonset once we have that
@benjaminhuo @wanjunlei how do you see it?

@benjaminhuo
Copy link
Member

I think it wouldn't be bad to have it on the statefulset as it can still be used there (although in a limited way). Obviously it would be best used on a daemonset once we have that @benjaminhuo @wanjunlei how do you see it?

Agree, merge this for now

@benjaminhuo benjaminhuo merged commit 70e213d into fluent:master May 24, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: Fluentd in_tail plugin
4 participants