Add ImagePullSecret for fluentd #891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenchajun
reviewed
Aug 27, 2023
| @@ -13,6 +13,9 @@ spec: | |||
| port: {{ .Values.fluentd.port }} | |||
| replicas: {{ .Values.fluentd.replicas }} | |||
| image: {{ .Values.fluentd.image.repository }}:{{ .Values.fluentd.image.tag }} | |||
| {{- if .Values.fluentd.imagePullSecrets }} | |||
| imagePullSecrets: | |||
| {{ toYaml .Values.fluentd.imagePullSecrets | indent 4 }} | |||
There was a problem hiding this comment.
{{- if .Values.fluentd.imagePullSecrets }}
imagePullSecrets:
{{ toYaml .Values.fluentd.imagePullSecrets | indent 4 }}
{{end}}
There seems to be an end missing here.
There was a problem hiding this comment.
@wenchajun Added, Thanks
Signed-off-by: rajan.sharma <rajan.sharma@razorpay.com>
Rajan-226
force-pushed
the
add_image_pull_secrets
branch
from
24148eb
to
0b998ed
Compare
wenchajun
approved these changes
Aug 28, 2023
benjaminhuo
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #879
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.:
We already have support for fluentd. It was just not added in values.yaml.
In FluentdSpec:
In MakeFluentdDaemonSet:
