Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[summerospp]add fluentbit http plugin #904

Merged
merged 4 commits into from Sep 4, 2023
Merged

Conversation

sjliu1
Copy link
Contributor

@sjliu1 sjliu1 commented Sep 1, 2023

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduced a user-facing change?


Additional documentation, usage docs, etc.:


sjliu1 and others added 2 commits September 1, 2023 23:16
Signed-off-by: sjliu1 <sj_liu123@163.com>
Signed-off-by: “sjliu1” <“sj_liu123@163.com”>
@benjaminhuo
Copy link
Member

@sjliu1 You need to sign you commit

@sjliu1 sjliu1 changed the title Http [summerospp]add fluentbit http plugin Sep 2, 2023
wenchajun
wenchajun previously approved these changes Sep 2, 2023
@sjliu1
Copy link
Contributor Author

sjliu1 commented Sep 2, 2023

@sjliu1 You need to sign you commit

Fixed.

// This sets the chunk size for incoming incoming JSON messages.
//These chunks are then stored/managed in the space available by buffer_max_size,default 512K.
// +kubebuilder:validation:Pattern:="^\\d+(k|K|KB|kb|m|M|MB|mb|g|G|GB|gb)?$"
BufferChunkSize string `json:"bufferchunkSize,omitempty"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
BufferChunkSize string `json:"bufferchunkSize,omitempty"`
BufferChunkSize string `json:"bufferChunkSize,omitempty"`

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed,thanks!

@@ -57,6 +57,8 @@ type InputSpec struct {
Forward *input.Forward `json:"forward,omitempty"`
// OpenTelemetry defines forward input plugin configuration
OpenTelemetry *input.OpenTelemetry `json:"openTelemetry,omitempty"`
// HTTP defines forward input plugin configuration
HTTP *input.OpenTelemetry `json:"http,omitempty"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
HTTP *input.OpenTelemetry `json:"http,omitempty"`
HTTP *input.HTTP `json:"http,omitempty"`

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed,thanks!

@benjaminhuo benjaminhuo merged commit a669907 into fluent:master Sep 4, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants