Expose ports on collector statefulset #917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grégory Cuellar <gregory.cuellar@gmail.com>
gregorycuellar
force-pushed
the
master
branch
from
e873e72
to
2c48004
Compare
benjaminhuo
approved these changes
Sep 12, 2023
|
@gregorycuellar Thank you for this ! |
|
@benjaminhuo do you know if a release is planned soon ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Pods created by the statefulset of a collector, doesn't expose the ports defined. Only, the service expose the ports.
This PR add those ports to the definition of the statefulset.
Which issue(s) this PR fixes:
Fixes #916
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: