Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sort custom resources by metadata.name #988

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

cw-Guo
Copy link
Contributor

@cw-Guo cw-Guo commented Nov 11, 2023

What this PR does / why we need it:

Currently, there is no determined order of clusterinputs, clusterfilters, and clusteroutputs. If a user wants to use fluentd rewrite_tag_filter, then unordered clusterfilters may affect the final results of log entries.

fluent-bit has similar feature.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduced a user-facing change?

Fluentd  clusterinputs, clusterfilters, and clusteroutputs will be sorted by metadata.name

Additional documentation, usage docs, etc.:


Signed-off-by: juicer <cwguoz@gmail.com>
@benjaminhuo
Copy link
Member

That's great

@benjaminhuo benjaminhuo merged commit 08b005b into fluent:master Nov 14, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants