Fix system user/group name in logrotate.d/fluentd again #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit bf66110. Note that fluent-package/templates/etc/logrotate.d/fluentd is used for not only deb, but also rpm. Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
kenhys
force-pushed
the
fix-logrotate-conf
branch
from
3ca44a8
to
9c94724
Compare
This is follow-up of fluent#592 to fix problem correctly. fluent-package/tempaltes/etc/logrotate.d/fluentd is used for deb and rpm, so it should support both of different system user/group respectively. Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
kenhys
force-pushed
the
fix-logrotate-conf
branch
from
9c94724
to
290c5fb
Compare
|
Extracted task which depends package type. |
|
Sorry for my late response. |
daipom
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is follow-up of #592 to fix problem correctly.
fluent-package/tempaltes/etc/logrotate.d/fluentd is used
for deb and rpm, so it should support both of different
system user/group respectively.