Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More licensing issues #2

Closed
jordansissel opened this issue Sep 17, 2014 · 4 comments
Closed

More licensing issues #2

jordansissel opened this issue Sep 17, 2014 · 4 comments

Comments

@jordansissel
Copy link

I had a glance at https://github.com/kiyoto/fluent-plugin-grok-parser/blob/master/lib/fluent/plugin/parser_grok.rb and much of it is very clearly a derivative of the ruby grok implementation, but the license on your project claims copyright on code that is copied directly and in other cases are pretty obvious derivative work of the jls-grok rubygem (jordansissel/ruby-grok).

Licensing and authorship in open source is a very important thing, and plagiarism must be avoided if communities are to work together.

Please do not claim copyright on that which you do not own.

@kiyoto
Copy link
Contributor

kiyoto commented Sep 17, 2014

Thanks for the feedback. First, I am sorry for my mistakes. Second, here are the steps I have taken to rectify the situation > df0c90b

@jordansissel
Copy link
Author

That license update only mentions the patterns, not the code that is copied or derived from the ruby-grok library itself. For some examples, many of the methods in this fluentd plugin are quite similar to the ruby-grok implementations (method names, instance variable names, implementations) , and the PATTERN_RE is copied almost exactly from ruby-grok without attribution.

@kiyoto
Copy link
Contributor

kiyoto commented Sep 17, 2014

Thanks for the further feedback. I updated the language to clarify that. 9319891 Also, parser_grok.rb has a comment that says much of its implementation is based on your code.

@jordansissel
Copy link
Author

Thanks much :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants