Use Ruby Kafka's ssl_ca_cert_file_path parameter to feed the CA certs #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergey Yedrikov <syedriko@redhat.com>
syedriko
force-pushed
the
ssl_ca_cert_file_path_array
branch
from
6ed6879
to
e8a2e06
Compare
|
/cc @kenhys |
|
The dependency just got approved: zendesk/ruby-kafka#905 (review) |
|
zendesk/ruby-kafka#905 has merged. |
|
ruby-kafka 1.4.0 has been released: https://rubygems.org/gems/ruby-kafka/versions/1.4.0
Although it's not described in CHANGELOG.md, it seems that it ships this feature too. |
ashie
approved these changes
Aug 26, 2021
Array support of ssl_ca_cert_file_path is needed: zendesk/ruby-kafka#905 fluent#410 Signed-off-by: Takuro Ashie <ashie@clear-code.com>
I've added the commit to this pull request. |
|
Merged. Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another take on #390, with a more correct way of fixing #287, where the Fluentd Kafka plugin doesn't need to know how to parse PEM certificates. This PR depends on zendesk/ruby-kafka#905.
It is also in line with #287 (comment), which I completely agree with.