feat(out_rdkafka2): add parameter use_default_for_unknown_partition_error
#491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…error` Signed-off-by: Ray Tung <code@raytung.net>
raytung
force-pushed
the
feat/out_rdkafka2_unknown_partition
branch
from
4dff548
to
51245c9
Compare
ashie
reviewed
May 30, 2023
| # RD_KAFKA_RESP_ERR__UNKNOWN_PARTITION | ||
| when :unknown_partition | ||
| if @use_default_for_unknown_partition_error && actual_topic != @default_topic | ||
| log.debug "failed writing to topic '#{actual_topic}' with error '#{e.to_s}'. Writing message to topic '#{@default_topic}'" |
There was a problem hiding this comment.
Shouldn't it be log.warn for this according to your comment in #489 (comment)?
There was a problem hiding this comment.
yeah I thought about it some more - because we require a config parameter to enter into this logic, I think it makes sense to debug log this instead since it is doing what it intends to do. And in the event where this config parameter is not set (default to false), it will simply bubble the exception upwards which will be logged by fluentd anyway.
There was a problem hiding this comment.
Yep, it's reasonable.
Thanks for clarification.
ashie
approved these changes
May 30, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements suggestion in #489 (comment)