Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use template_file for Data Streams #20

Merged
merged 3 commits into from Feb 16, 2022
Merged

Use template_file for Data Streams #20

merged 3 commits into from Feb 16, 2022

Conversation

anders-swanson
Copy link
Contributor

@anders-swanson anders-swanson commented Feb 14, 2022 •
edited by cosmo0920

Signed-off-by: Anders Swanson anders.swanson@oracle.com

Currently template_file parameter is not supported by datastream output. This would add creation of index template, it was not working before.

(check all that apply)

  • tests added
  • tests passing
  • README updated (if needed)
  • README Table of Contents updated (if needed)
  • History.md and version in gemspec are untouched
  • backward compatible

@anders-swanson
Datastream index template creation
f1c112c 
Signed-off-by: Anders Swanson <anders.swanson@oracle.com>
@anders-swanson
Add test
57e012f 
Signed-off-by: Anders Swanson <anders.swanson@oracle.com>
@anders-swanson
Test file
b46bb9e 
Signed-off-by: Anders Swanson <anders.swanson@oracle.com>
@anders-swanson anders-swanson changed the title Datastream index template creation Use template_file for Data Streams Feb 14, 2022
cosmo0920
cosmo0920 requested changes Feb 15, 2022
View reviewed changes
Copy link
Collaborator

@cosmo0920 cosmo0920 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your implementation is good. But, I found an issue for stability on unstable working connections.

lib/fluent/plugin/out_opensearch_data_stream.rb Show resolved Hide resolved
cosmo0920
cosmo0920 approved these changes Feb 16, 2022
View reviewed changes
Copy link
Collaborator

@cosmo0920 cosmo0920 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cosmo0920 cosmo0920 merged commit 2d534f9 into fluent:main Feb 16, 2022
@cosmo0920 cosmo0920 mentioned this pull request Feb 16, 2022
Closed
@anders-swanson anders-swanson deleted the datastream-template branch February 16, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cosmo0920 cosmo0920 cosmo0920 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anders-swanson @cosmo0920