Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use faraday 1.x explicitly #71

Merged
merged 1 commit into from Aug 9, 2022
Merged

Use faraday 1.x explicitly #71

merged 1 commit into from Aug 9, 2022

Conversation

ashie
Copy link
Member

@ashie ashie commented Aug 9, 2022

opensearch-transport 2.0.1 and 1.0.1 unlocks using faraday 2.x but
fluent-plugin-opensearch isn't ready for it, as a result out_opensearch
doesn't work on newly install.

Fix #70

Signed-off-by: Takuro Ashie ashie@clear-code.com

DESCRIPTION HERE

(check all that apply)

  • tests added
  • tests passing
  • README updated (if needed)
  • README Table of Contents updated (if needed)
  • History.md and version in gemspec are untouched
  • backward compatible

opensearch-transport 2.0.1 and 1.0.1 unlocks using faraday 2.x but
fluent-plugin-opensearch isn't ready for it, as a result out_opensearch
doesn't work on newly install.

Fix #70

Signed-off-by: Takuro Ashie <ashie@clear-code.com>
@ashie
Copy link
Member Author

ashie commented Aug 9, 2022

I tried faraday 2.x too but CI for ruby 2.x failed:
https://github.com/fluent/fluent-plugin-opensearch/tree/use-faraday-2

@ashie ashie requested a review from cosmo0920 August 9, 2022 07:51
@cosmo0920
Copy link
Collaborator

Oh, I didn't notice about it. Looks good.

@cosmo0920 cosmo0920 merged commit eb27be6 into main Aug 9, 2022
@cosmo0920 cosmo0920 deleted the use-faraday-1 branch August 9, 2022 08:20
@cosmo0920
Copy link
Collaborator

I'd released this change as v1.0.8. 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error=":excon is not registered on Faraday::Adapter" occurs on newly install
2 participants