Add a new parameter emit_mode #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Records in an event stream will be grouped by rewritten tag when `emit_mode` is `stream`. This will reduce IO cost. Fix #80 Signed-off-by: Kenji Okimoto <okimoto@clear-code.com>
Signed-off-by: Kenji Okimoto <okimoto@clear-code.com>
Signed-off-by: Kenji Okimoto <okimoto@clear-code.com>
Signed-off-by: Kenji Okimoto <okimoto@clear-code.com>
repeatedly
reviewed
Mar 12, 2019
repeatedly
reviewed
Mar 12, 2019
Because boolean is faster than symbol comparison. Signed-off-by: Kenji Okimoto <okimoto@clear-code.com>
Signed-off-by: Kenji Okimoto <okimoto@clear-code.com>
Because `batch` mode is good for popular in_tail / in_forward's case. Signed-off-by: Kenji Okimoto <okimoto@clear-code.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Records in an event stream will be grouped by rewritten tag when
emit_modeisstream. This will reduce IO cost.Fix #80