Enable format/inject plugin helper for Fluentd v0.14 #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove config-placeholders / plaintextformatter mixins
* add features to support removed mixins:
* enable hostname/uuid placeholders by itself (supported %{} style syntax is same with fluent-plugin-s3)
* switch to use "out_file" formatter in default, almost compatible with default plaintextformatter configuration
* make formatting timezone default in UTC
* make formatter/inject plugin helpers enabled to modify/format records in standard way
* add compat parameter converter for plaintextformatter for compatibility
|
@repeatedly Could you review this code? |
repeatedly
reviewed
Jan 26, 2017
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| Gem::Specification.new do |gem| | |||
| gem.name = "fluent-plugin-webhdfs" | |||
| gem.version = "0.5.3" | |||
| gem.version = "0.6.0rc1" | |||
There was a problem hiding this comment.
If you update code to work with only v0.14, upgrade major version.
http://docs.fluentd.org/articles/plugin-development#plugin-versioning-policy
|
I don't know the plaintextformatter but others are good for me. |
|
Let me merge this, and then fix the version number to |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #48.
This change does:
This plugin will be ready for Fluentd v0.14 after merging this patch.