Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't sed elasticsearch on non-elasticsearch images #161

Closed
jamielennox opened this issue Jul 3, 2018 · 1 comment
Closed

Don't sed elasticsearch on non-elasticsearch images #161

jamielennox opened this issue Jul 3, 2018 · 1 comment

Comments

@jamielennox
Copy link

The entrypoint script has a holdover of doing

if [ -z ${FLUENT_ELASTICSEARCH_USER} ] ; then
   sed -i  '/FLUENT_ELASTICSEARCH_USER/d' /fluentd/etc/${FLUENTD_CONF}
fi

if [ -z ${FLUENT_ELASTICSEARCH_PASSWORD} ] ; then
   sed -i  '/FLUENT_ELASTICSEARCH_PASSWORD/d' /fluentd/etc/${FLUENTD_CONF}
fi

I'm assuming it's for some legacy thing. Anyway, the way I use this image is I mount a custom configMap on /fluentd/etc/ and deal with my own config there.

I'm not using elastic search so i don't have those env variables set and so it tries to sed my fluentd.conf but sed fails because the destination is not writable.

Can we remove these statements? Why would we support a find and replace in fluent config, it can't be made to use #{ENV['X']}? They don't actually replace a real value just delete old ones.

If not can we at least isolate them to only be relevant to the elasticsearch image?

Workaround, if i set those env vars to any value it skips the sed and continues to work.

repeatedly added a commit that referenced this issue Jul 3, 2018
Remove sed from non Elasticsearch images. fixes #161
@repeatedly
Copy link
Member

Removed by #163

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants