Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merged_configure_proxy overwrites name of proxy #1013

Closed
okkez opened this issue Jun 1, 2016 · 0 comments · Fixed by #1015
Closed

merged_configure_proxy overwrites name of proxy #1013

okkez opened this issue Jun 1, 2016 · 0 comments · Fixed by #1015
Labels

Comments

@okkez
Copy link
Contributor

okkez commented Jun 1, 2016

The name of proxy object which is returned by Fluent::Configurable#merged_configure_proxy is Fluent::Plugin::Base. I expected real plugin name such as Fluent::Plugin::DummyInput.
This is not useful for debug.

https://github.com/fluent/fluentd/blob/master/lib/fluent/configurable.rb#L159..L167

configurables = ancestors.reverse.select{ |a| a.respond_to?(:configure_proxy) } # => [Fluent::PluginBase, ..., Fluent::Plugin::DummyInput]
configurables.map{ |a| a.configure_proxy(a.name || a.object_id.to_s) }.reduce(:merge)

In Fluentd v0.14.0:

merged_configure_proxy.name # => "Fluent::Plugin::Base"

I expected:

# For example, when we use in_dummy plugin
merged_configure_proxy.name # => "Fluent::Plugin::DummyInput"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants