Reduce delay before flush when large timekey and small timekey_wait a… #2291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re given. Signed-off-by: Masatake Iwasaki <iwasakims@gmail.com>
|
Thanks. Will check soon. |
|
Looks good. Thanks! |
|
Thanks for reviewing and merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When large timekey and relatively small timekey_wait are given, the delay before flush could be too long. The cause is running interval of enqueue thread which is set as timekey / 11.0. If timekey is 86400 (1 day), the interval is 7854 seconds. Even if timekey_wait is set to 600 seconds in this case, the actual delay before flush could be up to 600+7854 seconds. Taking timekey_wait into account for deciding enqueue thread interval would mitigate this.