Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support embedded Ruby code in section attributes. Fix #2273 #2295

Merged
merged 1 commit into from
Feb 18, 2019

Conversation

cosmo0920
Copy link
Contributor

Signed-off-by: Hiroshi Hatake hatake@clear-code.com

Signed-off-by: Hiroshi Hatake <hatake@clear-code.com>
@cosmo0920
Copy link
Contributor Author

cosmo0920 commented Feb 15, 2019

But this implementation does not permit the following configuration:

<source>
  @type tail
  path temp.log
  tag "docker.#{ENV['FLUENT_TAG']}"
  <parse>
    @type none
  </parse>
</source>

<match "docker.#{ENV['FLUENT_TAG']}".**> # Mixed case is NG
  @type stdout
</match>

<match docker.**>
  @type null
</match>

Should we also permit the above configuration? (Embedded Ruby code and plain text mixed attributes)

The below is OK scenario:

<source>
  @type tail
  path temp.log
  tag "docker.#{ENV['FLUENT_TAG']}"
  <parse>
    @type none
  </parse>
</source>

<match "docker.#{ENV['FLUENT_TAG']}.**"> # Entire Embedded Ruby code is OK
  @type stdout
</match>

<match docker.**>
  @type null
</match>

@repeatedly
Copy link
Member

Should we also permit the above configuration? (Embedded Ruby code and plain text mixed attributes)

I think no need support because current " quoted parameter doesn't allow mixied style.

@cosmo0920
Copy link
Contributor Author

Should we also permit the above configuration? (Embedded Ruby code and plain text mixed attributes)

I think no need support because current " quoted parameter doesn't allow mixied style.

Hmm, I see.

@repeatedly repeatedly merged commit fde2205 into master Feb 18, 2019
@repeatedly
Copy link
Member

Thanks!

@cosmo0920 cosmo0920 deleted the permit-to-use-environment-var-in-arg branch February 18, 2019 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants