Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

in_tail encoding enhancement #2305

Merged
merged 3 commits into from
Feb 22, 2019
Merged

in_tail encoding enhancement #2305

merged 3 commits into from
Feb 22, 2019

Conversation

repeatedly
Copy link
Member

  • Show warning message for same encoding case
  • Improve the performance using encode!
  • Replace bad character for encoding error

@repeatedly
in_tail: Replace bad character wheb encoding error happens
f84bd23 
Signed-off-by: Masahiro Nakagawa <repeatedly@gmail.com>
@repeatedly
in_tail: Log warning message for same encoding setting
5a010fc 
Signed-off-by: Masahiro Nakagawa <repeatedly@gmail.com>
@repeatedly
in_tail: Use encode! instead of encode to improve the performance
a41324c 
Signed-off-by: Masahiro Nakagawa <repeatedly@gmail.com>
@repeatedly repeatedly self-assigned this Feb 21, 2019
cosmo0920
cosmo0920 approved these changes Feb 22, 2019
View reviewed changes
Copy link
Contributor

@cosmo0920 cosmo0920 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good! 👍

@repeatedly repeatedly merged commit 08bfa39 into master Feb 22, 2019
@ganmacs ganmacs deleted the in_tail-encoding-enhancement branch July 11, 2019 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cosmo0920 cosmo0920 cosmo0920 approved these changes

Assignees

@repeatedly repeatedly

Labels
enhancement v1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@repeatedly @cosmo0920