add support for source_hostname_key and source_address_key on umatched syslog messages #2553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeber
changed the title
Unmatched messages should contain source_hostname_key or source_address_key if configured as this information is provided by the underlying udp oder tcp server and is available even if the message could not be parsed. This commit adds testcases for these options in combination with unmatched lines. Signed-off-by: Anselm Eberhardt <aeberhardt@dg-i.net>
aeber
force-pushed
the
feature_add_source_to_unmatched
branch
from
ecd158d
to
db29777
Compare
repeatedly
reviewed
Aug 13, 2019
Include source_address_key or source_hostname_key on unmatched lines when configured. This fixes the test cases added in e3b959b. Signed-off-by: Anselm Eberhardt <aeberhardt@dg-i.net>
aeber
force-pushed
the
feature_add_source_to_unmatched
branch
from
db29777
to
22ebe9b
Compare
|
Looks good. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Fixes #2552
What this PR does / why we need it:
Unmatched messages from the syslog input should contain
source_hostname_keyorsource_address_keyif configured as this information is provided by theunderlying udp oder tcp server and is available even if the message
could not be parsed.
This PR will add support for the expected behaviour of honoring
source_address_keyandsource_hostname_keyon unmatched lines.