Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dry run mode #2651

Merged
merged 7 commits into from Nov 5, 2019
Merged

Fix dry run mode #2651

merged 7 commits into from Nov 5, 2019

Commits on Oct 31, 2019

  1. Dump config if dry-run mode 

    This change had been introduced since
https://github.com/fluent/fluentd/pull/1580/files .

but even if dry-run mode, config need to show itself

Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
    @ganmacs
    ganmacs committed Oct 31, 2019
    Configuration menu
    Copy the full SHA
    5702b33 View commit details
    Browse the repository at this point in the history

  2. Add supervisor_mode to Engine class 

    and if supervisor_mode, worker_id returns -1 because
we need to identify worker0 and supervisor

Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
    @ganmacs
    ganmacs committed Oct 31, 2019
    Configuration menu
    Copy the full SHA
    6f0ae3b View commit details
    Browse the repository at this point in the history

  3. unify dry_run method and make @dry_run immutable 

    Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
    @ganmacs
    ganmacs committed Oct 31, 2019
    Configuration menu
    Copy the full SHA
    a1d6f36 View commit details
    Browse the repository at this point in the history

  4. unify the condition 

    Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
    @ganmacs
    ganmacs committed Oct 31, 2019
    Configuration menu
    Copy the full SHA
    1089d34 View commit details
    Browse the repository at this point in the history

  5. rearrange code 

    Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
    @ganmacs
    ganmacs committed Oct 31, 2019
    Configuration menu
    Copy the full SHA
    6b64cfc View commit details
    Browse the repository at this point in the history

  6. no need to assign dry_run to ivar 

    Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
    @ganmacs
    ganmacs committed Oct 31, 2019
    Configuration menu
    Copy the full SHA
    98e3034 View commit details
    Browse the repository at this point in the history

  7. fixed failed spec 

    Signed-off-by: Yuta Iwama <ganmacs@gmail.com>
    @ganmacs
    ganmacs committed Oct 31, 2019
    Configuration menu
    Copy the full SHA
    4db63ce View commit details
    Browse the repository at this point in the history