Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_in_tail: Remove meaningless test data for throttling tests #3408

Merged
merged 1 commit into from Jun 4, 2021

Conversation

ashie
Copy link
Member

@ashie ashie commented Jun 3, 2021

Which issue(s) this PR fixes:
none

What this PR does / why we need it:
Although throttling tests try many data, about half of them are
meaningless. Since these tests take 1-2 seconds per datum, they
should be removed to reduce whole test time.

Docs Changes:
none

Release Note:
none

Although throttling tests try many data, about half of them are
meaningless. Since these tests take 1-2 seconds per datum, they
should be removed to reduce whole test time.

Signed-off-by: Takuro Ashie <ashie@clear-code.com>
@ashie ashie force-pushed the remove-meaningless-test-data branch from 7ba0a85 to a492416 Compare June 3, 2021 08:51
@ashie
Copy link
Member Author

ashie commented Jun 3, 2021

In addition, removing them is more likely to avoid instability of CI environment.

@ashie ashie requested a review from cosmo0920 June 3, 2021 23:09
Copy link
Contributor

@cosmo0920 cosmo0920 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly. It is reasonable for me. 😁

@cosmo0920 cosmo0920 merged commit fa106f1 into fluent:master Jun 4, 2021
@ashie
Copy link
Member Author

ashie commented Jun 4, 2021

Thanks!

@ashie ashie deleted the remove-meaningless-test-data branch June 4, 2021 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants