MessagePackFactory: Make sure to reset local unpacker to prevent received broken data from affecting other receiving data #4178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes bug in c6c6c03 (fluent#2559). Received incomplete data must not affect data from other senders. Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
|
@tkoba66 Thanks for your report! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
None.
@tkoba66 reported this bug. Thanks!
When
in_forwardabnormally receives incomplete (broken) data, it can't correctly receive the next sent data.One of the main possible cases is as follows.
out_forward) to one receiver (in_forward).What this PR does / why we need it:
Fixes bug in c6c6c03 (#2559).
Received incomplete data must not affect data from other senders.
In #2559, the local unpacker started to be cached to improve the performance, but this caused the problem where corrupted data was unintentionally left in the cached unpacker, which resulted in the next data being broken too.
Docs Changes:
Not needed.
Release Note:
Same as the title.