Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sigdump to 0.2.5 #4225

Merged
merged 1 commit into from Jul 5, 2023
Merged

Update sigdump to 0.2.5 #4225

merged 1 commit into from Jul 5, 2023

Conversation

daipom
Copy link
Contributor

@daipom daipom commented Jul 4, 2023

Which issue(s) this PR fixes:
None.

What this PR does / why we need it:
In 0.2.5, the bug of wrong value of hash pairs and array elements fixed.

That version will be installed without this fix, but I think we should explicitly update the version.
(Is it correct?)

We can confirm it as follows on non-Windows. (On Windows, we can use fluent-ctl.)

$ sudo kill -CONT {pid}
$ less /tmp/sigdump-{pid}.log

Before: Too small Array and Hash sizes

...
   Array 61 elements
    Hash 8 pairs

After: Correct size

...
   Array 41,555 elements
    Hash 15,752 pairs

Docs Changes:
No need.

Release Note:
Fix wrong Object Array and Hash sizes of SIGDUMP.

ETC:
Should we merge this into v1.16 too?

In 0.2.5, the bug of wrong value of `hash pairs` and
`array elements` fixed.

Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
@ashie ashie merged commit e20697e into fluent:master Jul 5, 2023
13 of 16 checks passed
@ashie
Copy link
Member

ashie commented Jul 5, 2023

Should we merge this into v1.16 too?

Not always needed.
Even if we don't backport it, the latest version will be installed.
And we'll bundle latest version of sigdump explicitly for td-agent (fluent-package).

@daipom daipom deleted the update-sidgump branch July 5, 2023 00:50
@daipom
Copy link
Contributor Author

daipom commented Jul 5, 2023

Thanks for your review!

@daipom daipom added this to the v1.16.2 milestone Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants