logger: Fix cache for ignore_same_log_interval growing unlimitedly
#4229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 6, 2023
ashie
reviewed
Jul 7, 2023
With `ignore_same_log_interval`, the cache can grow unlimitedly. This limits the size to 1000. Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
daipom
force-pushed
the
fix-log-cache-growing-unlimitedly
branch
from
8452fb4
to
82fc146
Compare
|
Thanks! |
|
Thanks for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
What this PR does / why we need it:
With
ignore_same_log_interval, the cache can grow unlimitedly.This limits the size to 1000.
Specification:
If needed, we can make the max size configurable, but for now, I don't think we need it.
Docs Changes:
Adding an explanation to https://docs.fluentd.org/deployment/logging#ignore_same_log_interval is desirable.
Release Note:
Same as the title.