Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in_tail: Manage tail watchers that are rorate_wait state too #4334

Merged
merged 6 commits into from
Mar 8, 2024

Commits on Jan 16, 2024

  1. in_tail: Manage tail watchers under rorate_wait state

    After a tail watcher transitions to `rotate_wait` state, the
    `rotate_wait` timer is no longer managed by in_tail, it might cause
    unexpected behaviour. e.g.)
    
    * It's never unwatched when shutdown occurs before `rotate_wait` passed.
    * Needless `rotate_wait` timers are executed when it detects more
      rotations.
    
    This patch fixes such unexpected behaviour.
    
    Signed-off-by: Takuro Ashie <ashie@clear-code.com>
    ashie committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    ab81c16 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2024

  1. in_tail: Add test for fast rotation

    Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
    daipom committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    441b38b View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2024

  1. in_tail: Make deletion be done on the timer callback side

    Logic inside `detach_watcher()` should be independent of
    `rotate_wait`.
    
    Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
    daipom committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    341d8b8 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2024

  1. in_tail: Make closing io handler be done in closing phase

    Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
    daipom committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    b8315c7 View commit details
    Browse the repository at this point in the history
  2. in_tail: Remove old comments

    The comments was added in 76f246a.
    At that time, closing was done by event-loop.
    Now, the situation is completely different.
    
    Currently, there are comments about the `close_io` option in
    `shutdown()` and `close()`.
    So, it would be enough to remove these comments.
    
    Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
    daipom committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    13dd299 View commit details
    Browse the repository at this point in the history
  3. in_tail: Make the new tests stable

    `sleep 1s` is too short for `enable_stat_watcher false`.
    
    Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
    daipom committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    d28f32e View commit details
    Browse the repository at this point in the history